Bug 158691

Summary: WebRTC: Add media setup test where media is set up in one direction at a time
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211    
Attachments:
Description Flags
Proposed patch
eric.carlson: review+
Patch for landing none

Adam Bergkvist
Reported 2016-06-13 05:26:35 PDT
Setting up media in one direction at a time means completing a first offer/answer dialog with unidirectional media, and then sending an updated offer to add media in the other direction.
Attachments
Proposed patch (16.01 KB, patch)
2016-06-14 02:29 PDT, Adam Bergkvist 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (16.00 KB, patch)
2016-06-14 06:44 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2016-06-14 02:29:33 PDT
Created attachment 281248 [details] Proposed patch
Eric Carlson
Comment 2 2016-06-14 05:59:08 PDT
Comment on attachment 281248 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281248&action=review > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:12 > + description("Test setting up media between two RTCPeerConnection instances with one single SDP dialog."); Nit: "... with one single ..." -> "... with a single ..." > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:112 > + testPassed("Frist offer/answer dialog completed") Nit: "Frist" -> "First"
Adam Bergkvist
Comment 3 2016-06-14 06:44:18 PDT
Created attachment 281254 [details] Patch for landing
Adam Bergkvist
Comment 4 2016-06-14 06:45:43 PDT
(In reply to comment #2) > Comment on attachment 281248 [details] > Proposed patch Thanks for reviewing Eric. 'Patch for landing' submitted. > View in context: > https://bugs.webkit.org/attachment.cgi?id=281248&action=review > > > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:12 > > + description("Test setting up media between two RTCPeerConnection instances with one single SDP dialog."); > > Nit: "... with one single ..." -> "... with a single ..." Fixed. > > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:112 > > + testPassed("Frist offer/answer dialog completed") > > Nit: "Frist" -> "First" Fixed.
WebKit Commit Bot
Comment 5 2016-06-14 08:11:43 PDT
Comment on attachment 281254 [details] Patch for landing Clearing flags on attachment: 281254 Committed r202043: <http://trac.webkit.org/changeset/202043>
WebKit Commit Bot
Comment 6 2016-06-14 08:11:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.