Bug 158340

Summary: :hover CSS pseudo-class sometimes keeps matching ever after mouse has left the element
Product: WebKit Reporter: Chris Rebert <webkit>
Component: CSSAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: HasReduction, InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: OS X 10.11   
URL: https://jsfiddle.net/cvrebert/rgq9zwc2/
See Also: https://bugs.webkit.org/show_bug.cgi?id=159173
Bug Depends on:    
Bug Blocks: 159753    
Attachments:
Description Flags
Video of the bug in action
none
Patch
none
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch none

Chris Rebert
Reported 2016-06-02 22:27:39 PDT
Created attachment 280426 [details] Video of the bug in action Steps to reproduce: 1. Open https://jsfiddle.net/cvrebert/rgq9zwc2/ in WebKit Nightly or Safari 9. 2. Move the mouse pointer to the star in the lower-right corner. 3. Observe that a tooltip appears. 4. Move the mouse pointer vertically upward along the column of stars. Actual result: Several of the gray boxes turn blue and stay blue, indicating that the :hover pseudo-class is applying to several of them simultaneously. See attached video, courtesy of https://github.com/RopoMen Expected result: Only the box currently being hovered over should be blue. Each box should turn gray again immediately after the pointer moves outside of the box's respective bounds. Original Bootstrap bug: https://github.com/twbs/bootstrap/issues/20012
Attachments
Video of the bug in action (123.64 KB, video/mp4)
2016-06-02 22:27 PDT, Chris Rebert 		no flags
Details
Patch (13.64 KB, patch)
2016-06-20 21:04 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (13.64 KB, patch)
2016-06-20 21:10 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (671.59 KB, application/zip)
2016-06-20 22:05 PDT, Build Bot 		no flags
Details
Patch (14.60 KB, patch)
2016-06-21 21:12 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-06-20 16:51:52 PDT
I know what is up. Not looking forward to writing more tests though :(
Radar WebKit Bug Importer
Comment 2 2016-06-20 16:52:04 PDT
<rdar://problem/26905293>
Benjamin Poulain
Comment 3 2016-06-20 21:04:45 PDT
Created attachment 281709 [details] Patch
WebKit Commit Bot
Comment 4 2016-06-20 21:07:14 PDT
Attachment 281709 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:35: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 5 2016-06-20 21:10:45 PDT
Created attachment 281710 [details] Patch
Build Bot
Comment 6 2016-06-20 22:05:36 PDT
Comment on attachment 281710 [details] Patch Attachment 281710 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1539894 New failing tests: fast/css/ancestor-of-hovered-element-detached.html fast/css/ancestor-of-hovered-element-removed.html
Build Bot
Comment 7 2016-06-20 22:05:39 PDT
Created attachment 281713 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Benjamin Poulain
Comment 8 2016-06-20 22:22:00 PDT
I'll have to skip those tests on iOS before landing.
Simon Fraser (smfr)
Comment 9 2016-06-21 15:13:09 PDT
Comment on attachment 281710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281710&action=review Please fix or skip the test for iOS. > Source/WebCore/ChangeLog:14 > + -"a" starts being removed from the tree, its renderer are destroyed. its render is > Source/WebCore/ChangeLog:16 > + and call hoveredElementDidDetach(). calls > Source/WebCore/ChangeLog:20 > + and call hoveredElementDidDetach(). calls
Benjamin Poulain
Comment 10 2016-06-21 21:12:33 PDT
Created attachment 281812 [details] Patch
WebKit Commit Bot
Comment 11 2016-06-21 22:52:16 PDT
Comment on attachment 281812 [details] Patch Clearing flags on attachment: 281812 Committed r202324: <http://trac.webkit.org/changeset/202324>
WebKit Commit Bot
Comment 12 2016-06-21 22:52:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.