Bug 158007

Summary:

Swap search field's cancel and result button for RTL content.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, estade, rniwa, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Patch	none

zalan

Reported 2016-05-23 19:05:00 PDT

rdar://problem/25346475

Attachments
Patch (23.93 KB, patch) 2016-05-23 19:08 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.00 MB, application/zip) 2016-05-23 19:49 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.08 MB, application/zip) 2016-05-23 20:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (843.13 KB, application/zip) 2016-05-23 20:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.59 MB, application/zip) 2016-05-23 20:09 PDT, Build Bot	no flags	Details
Patch (35.13 KB, patch) 2016-05-24 12:01 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (881.31 KB, application/zip) 2016-05-24 12:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.05 MB, application/zip) 2016-05-24 12:32 PDT, Build Bot	no flags	Details
Patch (40.07 KB, patch) 2016-05-24 12:56 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (835.51 KB, application/zip) 2016-05-24 13:35 PDT, Build Bot	no flags	Details
Patch (43.65 KB, patch) 2016-05-24 13:51 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (29.36 KB, patch) 2016-05-24 15:16 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2016-05-23 19:08:41 PDT

Created attachment 279610 [details] Patch

Build Bot

Comment 2 2016-05-23 19:49:46 PDT

Comment on attachment 279610 [details] Patch Attachment 279610 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1372326 New failing tests: transitions/default-timing-function.html fast/css/text-overflow-input.html fast/forms/search-rtl.html

Build Bot

Comment 3 2016-05-23 19:49:49 PDT

Created attachment 279612 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-05-23 20:00:45 PDT

Comment on attachment 279610 [details] Patch Attachment 279610 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1372329 New failing tests: fast/css/text-overflow-input.html fast/forms/search-rtl.html

Build Bot

Comment 5 2016-05-23 20:00:47 PDT

Created attachment 279615 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-05-23 20:01:55 PDT

Comment on attachment 279610 [details] Patch Attachment 279610 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1372322 New failing tests: fast/forms/search-input-rtl.html fast/css/text-overflow-input.html fast/forms/search-rtl.html

Build Bot

Comment 7 2016-05-23 20:01:58 PDT

Created attachment 279616 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Build Bot

Comment 8 2016-05-23 20:09:20 PDT

Comment on attachment 279610 [details] Patch Attachment 279610 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1372332 New failing tests: fast/css/text-overflow-input.html fast/forms/search-rtl.html

Build Bot

Comment 9 2016-05-23 20:09:23 PDT

Created attachment 279617 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

zalan

Comment 10 2016-05-24 12:01:36 PDT

Created attachment 279680 [details] Patch

Build Bot

Comment 11 2016-05-24 12:28:54 PDT

Comment on attachment 279680 [details] Patch Attachment 279680 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1376171 New failing tests: fast/forms/search-rtl.html

Build Bot

Comment 12 2016-05-24 12:28:57 PDT

Created attachment 279686 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2016-05-24 12:32:27 PDT

Comment on attachment 279680 [details] Patch Attachment 279680 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1376174 New failing tests: fast/forms/search-rtl.html

Build Bot

Comment 14 2016-05-24 12:32:31 PDT

Created attachment 279688 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

zalan

Comment 15 2016-05-24 12:56:39 PDT

Created attachment 279693 [details] Patch

Build Bot

Comment 16 2016-05-24 13:35:55 PDT

Comment on attachment 279693 [details] Patch Attachment 279693 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1376398 New failing tests: fast/forms/search-input-rtl.html

Build Bot

Comment 17 2016-05-24 13:35:59 PDT

Created attachment 279698 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

zalan

Comment 18 2016-05-24 13:51:41 PDT

Created attachment 279700 [details] Patch

zalan

Comment 19 2016-05-24 15:16:08 PDT

Created attachment 279710 [details] Patch

WebKit Commit Bot

Comment 20 2016-05-25 12:40:26 PDT

Comment on attachment 279710 [details] Patch Clearing flags on attachment: 279710 Committed r201397: <http://trac.webkit.org/changeset/201397>

WebKit Commit Bot

Comment 21 2016-05-25 12:40:31 PDT

All reviewed patches have been landed. Closing bug.

Kent Tamura

Comment 22 2016-08-07 20:44:08 PDT

*** Bug 51499 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.