Bug 15739

Summary:

[Transforms] Selection smears on animated transform

Product:

WebKit

Reporter:

Maxwell Terpstra <max>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

mitz, simon.fraser

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac (Intel)

OS:

OS X 10.4

Bug Depends on:

21942, 22472

Bug Blocks:

15670

Attachments:

Description	Flags
Testcase that works fine	none
testcase with rotating replaced content	none
Testcase for selection on transformed image	none
Patch, testcase, changelog	mitz: review+

Maxwell Terpstra

Reported 2007-10-28 16:03:08 PDT

Sample URL pulled from blog comments. If the rotating graphic is selected, a selection highlight "smears" around the edges as it rotates.

Attachments
Testcase that works fine (1.12 KB, text/html) 2008-11-20 18:04 PST, Simon Fraser (smfr)	no flags	Details
testcase with rotating replaced content (955 bytes, text/html) 2008-11-21 00:17 PST, Maxwell Terpstra	no flags	Details
Testcase for selection on transformed image (685 bytes, text/html) 2008-11-21 09:00 PST, Simon Fraser (smfr)	no flags	Details
Patch, testcase, changelog (5.66 KB, patch) 2008-12-06 16:56 PST, Simon Fraser (smfr)	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2008-11-20 16:36:16 PST

Testcase (http://picknewtemplate.blogspot.com/2007/10/webkit-gets-element-transforms.html) has gone away.

Simon Fraser (smfr)

Comment 2 2008-11-20 18:04:52 PST

Created attachment 25327 [details] Testcase that works fine

Simon Fraser (smfr)

Comment 3 2008-11-20 18:05:14 PST

Marking WorksForMe based on testcase.

Maxwell Terpstra

Comment 4 2008-11-21 00:17:57 PST

Created attachment 25343 [details] testcase with rotating replaced content Shows selection smearing in Webkit r38592

Maxwell Terpstra

Comment 5 2008-11-21 00:19:21 PST

The bug only happens when replaced content is rotated -- see new attached test-case.

Simon Fraser (smfr)

Comment 6 2008-11-21 09:00:07 PST

Thanks for the testcase; it reproduced in TOT. It actually looks like the selection rendering for the replaced element is wrong as soon as the replace element gets a transform. Testcase coming.

Simon Fraser (smfr)

Comment 7 2008-11-21 09:00:56 PST

Created attachment 25355 [details] Testcase for selection on transformed image

Simon Fraser (smfr)

Comment 8 2008-12-06 16:56:40 PST

Created attachment 25824 [details] Patch, testcase, changelog

Simon Fraser (smfr)

Comment 9 2008-12-06 17:04:07 PST

r39072 = 0e9a7ee0d9d8eee03464f6aa301ba2000ab089ca (trunk) M WebCore/ChangeLog M WebCore/rendering/RenderReplaced.cpp A LayoutTests/platform/mac/fast/replaced/selection-rect-transform-expected.png A LayoutTests/platform/mac/fast/replaced/selection-rect-transform-expected.txt A LayoutTests/platform/mac/fast/replaced/selection-rect-transform-expected.checksum M LayoutTests/ChangeLog A LayoutTests/fast/replaced/selection-rect-transform.html r39073 = 41705c6dcf11fb008cdba307fcdc8648d2b5badf (trunk)

Note You need to log in before you can comment on or make changes to this bug.