Bug 157179
| Summary: | [GTK] Drag and drop can't be tested with WebKitTestRunner | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | bugs-noreply, carlosg, clopez, emilio, lforschler, magomez, mcatanzaro |
| Priority: | P2 | Keywords: | Gtk, LayoutTestFailure |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=42194 | ||
Carlos Garcia Campos
The problem is that GTK+ is emitting the drag and drop events, because the drag and drop context is not handling the synthetic events generated by the EventSenderProxy. So, for example, when we generate a GDK_MOTION_NOTIFY by EventSenderProxy::mouseMoveTo(), the GdkDragContext doesn't handle that event and DRAG_MOTION is not called preventing the rest of the drag and drop protocol from working properly. So, in our tests we are never emitting the ondragenter and ondragover. I don't know if we can emulate it somehow, but we currently have several tests in the TestExpectation file pointing to a fixed bug, so we should at least update them to point to this bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Committed r200366: <http://trac.webkit.org/changeset/200366>
Carlos Garcia Campos
webkit-patch closed this, I just updated the test expectations in r200366, re-opening.
Michael Catanzaro
Layout test plugins/mouse-events.html, marked against this bug, has been timing out for a while now, first recorded in r191879. Updating expectations accordingly.
Carlos Garcia Campos
It seems in wayland dnd events are generated, but ends up crashing. Probably because synthesized events generated them, but I don't really know.
Carlos Alberto Lopez Perez
Expectations updated at: https://trac.webkit.org/changeset/213516/trunk/LayoutTests/platform/gtk-wayland/TestExpectations
Miguel Gomez
Adding proper expectations for these tests:
webkit.org/b/157179 editing/pasteboard/4989774.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-line-endings-002.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-list-002.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-list-003.html [ Failure Pass ]
Miguel Gomez
(In reply to Miguel Gomez from comment #6)
> Adding proper expectations for these tests:
>
> webkit.org/b/157179 editing/pasteboard/4989774.html [ Failure Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-line-endings-002.html [ Failure
> Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-list-002.html [ Failure Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-list-003.html [ Failure Pass ]
I've moved these to https://bugs.webkit.org/show_bug.cgi?id=198828 in the expectations, as I think they aren't related to drag&drop
Carlos Garcia Campos
*** Bug 202898 has been marked as a duplicate of this bug. ***