Bug 157124

Summary: [ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 157265    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2016-04-28 01:19:57 PDT
[ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard
Attachments
Patch (3.34 KB, patch)
2016-04-28 01:22 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-04-28 01:22:46 PDT
Created attachment 277606 [details] Patch
Keith Miller
Comment 2 2016-04-28 06:34:50 PDT
Comment on attachment 277606 [details] Patch r=me
Yusuke Suzuki
Comment 3 2016-04-29 03:46:23 PDT
Comment on attachment 277606 [details] Patch Thank you for your review!
WebKit Commit Bot
Comment 4 2016-04-29 04:35:57 PDT
Comment on attachment 277606 [details] Patch Clearing flags on attachment: 277606 Committed r200239: <http://trac.webkit.org/changeset/200239>
WebKit Commit Bot
Comment 5 2016-04-29 04:36:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.