Bug 156683

Summary: libjavascriptcoregtk-4.0.dylib is no longer installed
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac none

Jeremy Huddleston Sequoia
Reported 2016-04-17 16:04:13 PDT
libjavascriptcoregtk-4.0.dylib is not installed by 'make install' in r199646. Last known good was r198900. Multiple unrelated build failures plague simple bisection.
Attachments
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac (1.75 KB, patch)
2016-04-17 17:09 PDT, Jeremy Huddleston Sequoia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Huddleston Sequoia
Comment 1 2016-04-17 16:07:44 PDT
Looks like it was caused by https://bugs.webkit.org/show_bug.cgi?id=156268 More incorrect assumptions that APPLE == Mac.
Jeremy Huddleston Sequoia
Comment 2 2016-04-17 17:09:54 PDT
Created attachment 276613 [details] 0001-Fix-incorrect-assumption-that-APPLE-implies-Mac This patch fixes the issue and is being used now by MacPorts.
Alex Christensen
Comment 3 2016-04-17 23:01:20 PDT
Comment on attachment 276613 [details] 0001-Fix-incorrect-assumption-that-APPLE-implies-Mac My bad
WebKit Commit Bot
Comment 4 2016-04-17 23:52:27 PDT
Comment on attachment 276613 [details] 0001-Fix-incorrect-assumption-that-APPLE-implies-Mac Clearing flags on attachment: 276613 Committed r199651: <http://trac.webkit.org/changeset/199651>
WebKit Commit Bot
Comment 5 2016-04-17 23:52:31 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 6 2016-04-18 00:08:27 PDT
There's probably a similar assumption in WebKit2/CMakeLists.txt.
Alex Christensen
Comment 7 2016-04-18 00:14:28 PDT
(In reply to comment #6) > There's probably a similar assumption in WebKit2/CMakeLists.txt. Fixed in https://bugs.webkit.org/show_bug.cgi?id=156679
Note You need to log in before you can comment on or make changes to this bug.