Bug 156662

Summary: vertical-align doesn't seem to be intuitive/correct
Product: WebKit Reporter: Nick S <nschubach>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

Nick S
Reported 2016-04-16 09:30:57 PDT
1. http://codepen.io/nschubach/pen/QNrdZg?editors=0100 2. http://codepen.io/nschubach/pen/oxdBaR?editors=1100 What is the expected behavior? The middle aligned container should line up with the text line then the top/bottom containers should line up to that. What went wrong? The current implementation seems to pick random alignment rules. I can't tell intuitively what is going on with the webkit implementation. It appears as though the text is picking some kind of ratio placement. I think Gecko nailed the proper alignment with this by aligning the text specific alignment before the top/bottom. Webkit seems to have an OoO issue here and depending on what rule is applied first it changes the alignment. Examples on Gecko: 1. http://i.imgur.com/MVAnlVA.png (Gecko) 2. http://i.imgur.com/YNODy7j.png (Chromium Left / Gecko Right)
Attachments
Patch (9.68 KB, patch)
2023-04-02 06:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (9.80 KB, patch)
2023-04-02 19:53 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-07-14 15:39:31 PDT
This continues to be an issue in Safari 15.5. The rectangle marked '6' has the wrong baseline.
Radar WebKit Bug Importer
Comment 2 2022-07-14 15:39:41 PDT
<rdar://problem/97039168>
Ahmad Saleem
Comment 4 2023-04-01 16:31:58 PDT
@Alan - this Blink merge can be done in Legacy Inline Layout but if you have plan to take care of it in near future, I can hold-off. Else I can try local build and see if it fixes and then can do PR to fix this bug.
alan
Comment 5 2023-04-02 06:49:58 PDT
Created attachment 465734 [details] Patch
alan
Comment 6 2023-04-02 06:52:26 PDT
(In reply to Ahmad Saleem from comment #4) > @Alan - this Blink merge can be done in Legacy Inline Layout but if you have > plan to take care of it in near future, I can hold-off. Else I can try local > build and see if it fixes and then can do PR to fix this bug. While legacy line layout is hardly used on trunk anymore, I think it would be good to get I fixed. In the meantime I am hijacking this bugzilla for the IFC fix. -it should not stop you from reusing it for the merge though.
alan
Comment 7 2023-04-02 07:57:21 PDT
it probably needs some rebaselining.
alan
Comment 8 2023-04-02 19:53:24 PDT
Created attachment 465740 [details] [fast-cq]Patch
EWS
Comment 9 2023-04-03 06:43:51 PDT
Committed 262506@main (a194f90ccc4e): <https://commits.webkit.org/262506@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465740 [details].
alan
Comment 10 2023-09-06 07:13:26 PDT
*** Bug 215580 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.