Bug 156597

Summary: [css-grid] Fix positioned items with content alignment
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 156589    
Bug Blocks: 60731, 156623    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2016-04-14 13:57:42 PDT
Like in the case of gaps (bug #156288), positioned items are not working properly with content alignment. This has been fixed in Blink already: https://codereview.chromium.org/1870623002/
Attachments
Patch (44.55 KB, patch)
2016-04-14 14:00 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (41.73 KB, patch)
2016-04-14 14:01 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-04-14 14:00:43 PDT
Created attachment 276423 [details] Patch The patch has been developed on top of patch for bug #156589 (so it doesn't apply in trunk).
Manuel Rego Casasnovas
Comment 2 2016-04-14 14:01:50 PDT
Created attachment 276424 [details] Patch
Darin Adler
Comment 3 2016-04-16 10:44:30 PDT
Comment on attachment 276424 [details] Patch Annoying to have these tests that just write out PASS PASS PASS. Would be nicer some day to use reference tests or to pave the tests write something more about what they are testing so if something fails you can get a better understanding of what.
Manuel Rego Casasnovas
Comment 4 2016-04-18 01:17:26 PDT
Comment on attachment 276424 [details] Patch Thanks for the review. The problem with reference tests is the 800x600 viewport size, we would need a lot of different tests to check all the cases or use smaller sizes for everything so it'd be harder to debug. I agree that the tests full of PASS are not very nice, but when they fail they provide quite a lot of information.
WebKit Commit Bot
Comment 5 2016-04-18 01:19:54 PDT
Comment on attachment 276424 [details] Patch Clearing flags on attachment: 276424 Committed r199657: <http://trac.webkit.org/changeset/199657>
WebKit Commit Bot
Comment 6 2016-04-18 01:19:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.