Bug 155807

Summary: [ES6] Add Proxy based tests for RegExp.prototype[@@match]
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 155829    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Updated Patch - Removed Tabs saam: review+

Michael Saboff
Reported 2016-03-23 14:10:57 PDT
In <https://bugs.webkit.org/show_bug.cgi?id=155711> after change set r198554 was landed, it was suggested that we add more Proxy based tests to verify standards conformance. This would include handling the semantics issue raise in this comment: > > Source/JavaScriptCore/builtins/RegExpPrototype.js:59 > > + if (regexp.exec !== @RegExp.prototype.@exec && typeof(regexp.exec) === "function") { > Also, I'm not sure this is correct. You're calling "get" twice here. That is > an observable > operation. It looks like RegExpExec only does this get once in the spec.
Attachments
Patch (7.58 KB, patch)
2016-03-24 07:34 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated Patch - Removed Tabs (7.59 KB, patch)
2016-03-24 07:42 PDT, Michael Saboff 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-23 21:23:24 PDT
<rdar://problem/25331854>
Michael Saboff
Comment 2 2016-03-24 07:34:04 PDT
Created attachment 274831 [details] Patch
WebKit Commit Bot
Comment 3 2016-03-24 07:36:41 PDT
Attachment 274831 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/tests/stress/regexp-match-proxy.js:102: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/tests/stress/regexp-match-proxy.js:137: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 4 2016-03-24 07:42:16 PDT
Created attachment 274832 [details] Updated Patch - Removed Tabs
Saam Barati
Comment 5 2016-03-24 08:41:08 PDT
Comment on attachment 274832 [details] Updated Patch - Removed Tabs r=me Does es6.yaml also need to be updated?
Michael Saboff
Comment 6 2016-03-24 09:13:23 PDT
(In reply to comment #5) > Comment on attachment 274832 [details] > Updated Patch - Removed Tabs > > r=me > Does es6.yaml also need to be updated? Yes it does, so I'll do it before landing.
Michael Saboff
Comment 7 2016-03-24 09:13:45 PDT
Committed r198625: <http://trac.webkit.org/changeset/198625>
Note You need to log in before you can comment on or make changes to this bug.