Bug 155639

Summary:

Use Fraction* parameters from the OpenType MATH table

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

http://tests.mathml-association.org/mathml/presentation-markup/fractions/frac-parameters-1.html

Bug Depends on:

133845, 153917, 155638, 158884

Bug Blocks:

118737, 122297, 155714

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	bfulgham: review+
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none

Frédéric Wang (:fredw)

Reported 2016-03-18 08:33:48 PDT

The refactoring of bug 153917 tries to preserve the old layout for <mfrac>. We can improve it a bit by using the following parameters: DenominatorDisplayStyleGapMin DenominatorDisplayStyleShiftDown DenominatorGapMin DenominatorShiftDown NumeratorDisplayStyleGapMin NumeratorDisplayStyleShiftDown NumeratorGapMin NumeratorShiftDown FractionRuleThickness

Attachments
Patch (168.05 KB, patch) 2016-03-20 08:14 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (171.73 KB, patch) 2016-04-26 09:04 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (169.03 KB, patch) 2016-06-25 00:40 PDT, Frédéric Wang (:fredw)	bfulgham: review+	Details Formatted Diff Diff
Patch (169.35 KB, patch) 2016-07-08 06:09 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.22 MB, application/zip) 2016-07-08 06:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.06 MB, application/zip) 2016-07-08 06:49 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (964.90 KB, application/zip) 2016-07-08 06:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.43 MB, application/zip) 2016-07-08 07:07 PDT, Build Bot	no flags	Details
Patch (232.73 KB, patch) 2016-07-08 07:45 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2016-03-20 08:14:35 PDT

Created attachment 274539 [details] Patch

Frédéric Wang (:fredw)

Comment 2 2016-04-26 09:04:44 PDT

Created attachment 277383 [details] Patch

Frédéric Wang (:fredw)

Comment 3 2016-06-25 00:40:08 PDT

Created attachment 282057 [details] Patch

Brent Fulgham

Comment 4 2016-07-07 13:34:26 PDT

Comment on attachment 282057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282057&action=review This looks fine, but doesn't apply against trunk. Is there a related patch is should depend on? > Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:52 > , m_denominatorAlign(FractionAlignmentCenter) Could all of these constant initializations be moved to the header file as C++11 format? > Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:248 > + return Optional<int>(static_cast<int>(lroundf(m_ascent))); "lroundf" should be std::lround(m_ascent) You might need to #include <cmath>

Frédéric Wang (:fredw)

Comment 5 2016-07-08 06:09:16 PDT

Created attachment 283143 [details] Patch

Build Bot

Comment 6 2016-07-08 06:40:38 PDT

Comment on attachment 283143 [details] Patch Attachment 283143 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1646766 New failing tests: mathml/presentation/fractions-positions.html mathml/presentation/roots.xhtml

Build Bot

Comment 7 2016-07-08 06:40:41 PDT

Created attachment 283146 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-07-08 06:49:35 PDT

Comment on attachment 283143 [details] Patch Attachment 283143 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1646779 New failing tests: mathml/presentation/stretchy-depth-height-symmetric.html mathml/presentation/fractions-positions.html mathml/presentation/roots.xhtml

Build Bot

Comment 9 2016-07-08 06:49:40 PDT

Created attachment 283148 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Build Bot

Comment 10 2016-07-08 06:55:46 PDT

Comment on attachment 283143 [details] Patch Attachment 283143 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1646837 New failing tests: mathml/presentation/fractions-positions.html mathml/presentation/roots.xhtml

Build Bot

Comment 11 2016-07-08 06:55:49 PDT

Created attachment 283150 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-07-08 07:07:12 PDT

Comment on attachment 283143 [details] Patch Attachment 283143 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1646848 New failing tests: mathml/presentation/fractions-positions.html mathml/presentation/roots.xhtml

Build Bot

Comment 13 2016-07-08 07:07:16 PDT

Created attachment 283155 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Frédéric Wang (:fredw)

Comment 14 2016-07-08 07:45:16 PDT

Created attachment 283158 [details] Patch

Frédéric Wang (:fredw)

Comment 15 2016-07-08 08:31:37 PDT

Committed r202979: <http://trac.webkit.org/changeset/202979>

Note You need to log in before you can comment on or make changes to this bug.