Bug 154737

Summary: Silence leaks under TextCodecICU::registerCodecs
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, glenn, lforschler
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=118505
Attachments:
Description Flags
proposed patch
none
proposed patch none

Alexey Proskuryakov
Reported 2016-02-26 10:53:37 PST
Bug 118505: TextCodecICU::registerCodecs is leaking. Probably not worth the effort to fix now, so let's silence it.
Attachments
proposed patch (1.42 KB, patch)
2016-02-26 10:54 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (1.42 KB, patch)
2016-02-26 11:00 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-02-26 10:54:45 PST
Created attachment 272341 [details] proposed patch
WebKit Commit Bot
Comment 2 2016-02-26 10:57:00 PST
Attachment 272341 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/leakdetector.py:57: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2016-02-26 11:00:38 PST
Created attachment 272342 [details] proposed patch With more pep8 happiness.
WebKit Commit Bot
Comment 4 2016-02-27 16:40:12 PST
Comment on attachment 272342 [details] proposed patch Clearing flags on attachment: 272342 Committed r197262: <http://trac.webkit.org/changeset/197262>
WebKit Commit Bot
Comment 5 2016-02-27 16:40:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.