Bug 154357

Summary: Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, darin, esprehn+autocc, kondapallykalyan, l.krok, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154120    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-02-17 13:52:29 PST
http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test after <http://trac.webkit.org/changeset/196648>. Previously it did not redirect and it does not redirect either in other browsers. It redirects to http://w3c-test.org/html/dom/undefined
Attachments
Patch (5.48 KB, patch)
2016-02-17 14:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-17 13:56:25 PST
I think the problem is that our Location.assign() / Location.replace() should take a mandatory parameter but it is optional in WebKit. The test tries to call these operations without parameter to make sure it throws. However, in our case, it does NOT throw and it calls the function with the string "undefined" instead.
Chris Dumez
Comment 2 2016-02-17 14:39:34 PST
Created attachment 271593 [details] Patch
WebKit Commit Bot
Comment 3 2016-02-17 21:44:09 PST
Comment on attachment 271593 [details] Patch Clearing flags on attachment: 271593 Committed r196742: <http://trac.webkit.org/changeset/196742>
WebKit Commit Bot
Comment 4 2016-02-17 21:44:14 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2016-05-24 22:07:42 PDT
*** Bug 125221 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.