Bug 154330

Summary: Regression(r196648): window.showModalDialog is no longer undefined if the client does not allow showing modal dialog
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, darin, ggaren, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154120    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-02-16 22:09:28 PST
window.showModalDialog is no longer undefined if the client does not allow showing modal dialog after r196648. We did not have test coverage for this :(
Attachments
Patch (11.71 KB, patch)
2016-02-16 22:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.94 KB, patch)
2016-02-16 22:24 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.89 KB, patch)
2016-02-17 08:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.89 KB, patch)
2016-02-17 08:58 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-16 22:18:47 PST
Created attachment 271539 [details] Patch
Chris Dumez
Comment 2 2016-02-16 22:24:27 PST
Created attachment 271540 [details] Patch
Gavin Barraclough
Comment 3 2016-02-16 23:46:58 PST
Comment on attachment 271540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271540&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:288 > + } I think there is a bug here that this will do the wrong thing if your DOM contains an item named "showModalDialog" – the named getter will fail t pick it up. I think you can easily fix by replacing: > if (!DOMWindow::canShowModalDialog(frame)) { > slot.setUndefined(); > return false; > } With: > if (!DOMWindow::canShowModalDialog(frame)) > return jsDOMWindowGetOwnPropertySlotNamedItemGetter(thisObject, *frame, exec, propertyName, slot);
Chris Dumez
Comment 4 2016-02-17 08:57:01 PST
Created attachment 271558 [details] Patch
Chris Dumez
Comment 5 2016-02-17 08:58:06 PST
Created attachment 271559 [details] Patch
Chris Dumez
Comment 6 2016-02-17 08:58:28 PST
(In reply to comment #3) > Comment on attachment 271540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271540&action=review > > > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:288 > > + } > > I think there is a bug here that this will do the wrong thing if your DOM > contains an item named "showModalDialog" – the named getter will fail t pick > it up. > > I think you can easily fix by replacing: > > > if (!DOMWindow::canShowModalDialog(frame)) { > > slot.setUndefined(); > > return false; > > } > > With: > > > if (!DOMWindow::canShowModalDialog(frame)) > > return jsDOMWindowGetOwnPropertySlotNamedItemGetter(thisObject, *frame, exec, propertyName, slot); Fixed and added test coverage for this.
WebKit Commit Bot
Comment 7 2016-02-17 11:31:08 PST
Comment on attachment 271559 [details] Patch Clearing flags on attachment: 271559 Committed r196706: <http://trac.webkit.org/changeset/196706>
WebKit Commit Bot
Comment 8 2016-02-17 11:31:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.