Bug 154313

Summary: Implement Proxy.[[HasProperty]]
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154081    
Bug Blocks: 35731    
Attachments:
Description Flags
WIP
none
patch
none
patch fpizlo: review+

Saam Barati
Reported 2016-02-16 15:22:26 PST
...
Attachments
WIP (23.36 KB, patch)
2016-02-18 00:21 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (14.92 KB, patch)
2016-02-18 15:51 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (16.30 KB, patch)
2016-02-18 15:54 PST, Saam Barati 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-02-18 00:21:54 PST
Created attachment 271641 [details] WIP Basically done, just need to write tests. This contains some of the patch for [[GetOwnProperty]], so we need to wait for that to land before landing this.
Saam Barati
Comment 2 2016-02-18 15:51:37 PST
Created attachment 271707 [details] patch
WebKit Commit Bot
Comment 3 2016-02-18 15:54:04 PST
Attachment 271707 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ProxyObject.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 4 2016-02-18 15:54:22 PST
Created attachment 271709 [details] patch with a changelog this time
WebKit Commit Bot
Comment 5 2016-02-18 15:56:34 PST
Attachment 271709 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ProxyObject.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 6 2016-02-18 17:08:24 PST
landed in: http://trac.webkit.org/changeset/196789
Note You need to log in before you can comment on or make changes to this bug.