Bug 154230

Summary: XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, ggaren, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget
Bug Depends on: 154171    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2016-02-14 18:33:30 PST
XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Attachments
WIP Patch (19.10 KB, patch)
2016-02-14 21:55 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (44.17 KB, patch)
2016-02-14 22:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-14 19:58:46 PST
Both Firefox and Chrome implement XMLHttpRequestEventTarget and expose it on the global Window object.
Chris Dumez
Comment 2 2016-02-14 21:55:28 PST
Created attachment 271325 [details] WIP Patch
WebKit Commit Bot
Comment 3 2016-02-14 21:57:47 PST
Attachment 271325 [details] did not pass style-queue: ERROR: Source/WebCore/xml/XMLHttpRequestEventTarget.h:34: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2016-02-14 22:18:57 PST
Created attachment 271326 [details] Patch
Alex Christensen
Comment 5 2016-02-15 13:08:43 PST
Comment on attachment 271326 [details] Patch r=me. As I've been glancing at the XHR spec, I've wondered why we didn't have this and couldn't think of a good reason other than "nobody's done it yet".
WebKit Commit Bot
Comment 6 2016-02-15 14:03:04 PST
Comment on attachment 271326 [details] Patch Clearing flags on attachment: 271326 Committed r196599: <http://trac.webkit.org/changeset/196599>
WebKit Commit Bot
Comment 7 2016-02-15 14:03:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.