Bug 15422

Summary: Implement getComputedStyle support for SVG CSS properties
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 15348    
Attachments:
Description Flags
fix
sam: review-
improved patch (including added test case) (size due to search-replace changes) hyatt: review+

Eric Seidel (no email)
Reported 2007-10-08 00:28:50 PDT
Implement getComputedStyle support for SVG CSS properties the attached patch does just that (and thus works around the issue seen in bug 15348). This is not a complete implementation of getComputedStyle for SVG, but it's close enough to get us started (and make the inspector work).
Attachments
fix (80.81 KB, patch)
2007-10-08 00:37 PDT, Eric Seidel (no email) 		sam: review-
DetailsFormatted DiffDiff
improved patch (including added test case) (size due to search-replace changes) (132.33 KB, patch)
2007-10-08 12:57 PDT, Eric Seidel (no email) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-10-08 00:37:00 PDT
Created attachment 16586 [details] fix
Eric Seidel (no email)
Comment 2 2007-10-08 00:49:37 PDT
Wow. Being able to use the inspector makes the Sun Labs Lively Kernel much more interesting! :)
Nikolas Zimmermann
Comment 3 2007-10-08 09:38:38 PDT
Comment on attachment 16586 [details] fix Nice patch.
Sam Weinig
Comment 4 2007-10-08 10:20:56 PDT
Comment on attachment 16586 [details] fix This needs layouttests. r-
Eric Seidel (no email)
Comment 5 2007-10-08 12:57:24 PDT
Created attachment 16591 [details] improved patch (including added test case) (size due to search-replace changes) I implemented a couple more getComputedStyle properties to get rid to so many error logs in the console.
Dave Hyatt
Comment 6 2007-10-08 13:20:31 PDT
Comment on attachment 16591 [details] improved patch (including added test case) (size due to search-replace changes) r=me
Eric Seidel (no email)
Comment 7 2007-10-08 13:48:36 PDT
landed on feature-branch as r26109.
Note You need to log in before you can comment on or make changes to this bug.