Bug 154160

Summary: Update ICU header files to version 52
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andy, commit-queue, ggaren, keith_miller, mark.lam, mmaxfield, msaboff, rniwa, saam, sukolsak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 147605    
Attachments:
Description Flags
Patch
none
Patch for landing none

Sukolsak Sakshuwong
Reported 2016-02-12 01:33:14 PST
We are using the header files from ICU 4.6.1. To implement Intl.NumberFormat, we need to use UNUM_CURRENCY_ISO and UNUM_CURRENCY_PLURAL, which are only available in ICU 4.8+. It seems that we have already included a header file from ICU 52 (unumsys.h) and are using some functions in it. So, we should update every header file to version 52.
Attachments
Patch (1.48 MB, patch)
2016-02-12 01:48 PST, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.48 MB, patch)
2016-02-12 11:25 PST, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2016-02-12 01:48:38 PST
Created attachment 271151 [details] Patch
Alex Christensen
Comment 2 2016-02-12 08:54:04 PST
Comment on attachment 271151 [details] Patch http://opensource.apple.com/release/os-x-1010/ indicates that Yosemite has ICU 53, so this shouldn't cause any problems.
WebKit Commit Bot
Comment 3 2016-02-12 09:43:49 PST
Comment on attachment 271151 [details] Patch Rejecting attachment 271151 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 271151, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 196476 = 9041759358723908a9cd68bcdaa669d21174f33a r196478 = 2b0e56e1aa40601f61bb66848dd64c0c05cadda5 r196479 = 83cdc5b3ac8ec8bcdcf74312f84541bd24522413 r196480 = 603c92044c256d6e24e55339da42b99d537fa607 r196481 = e6eb0eabb64d9e1f2480492b5b881754bc992491 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/820031
Sukolsak Sakshuwong
Comment 4 2016-02-12 11:25:27 PST
Created attachment 271193 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-02-12 12:15:40 PST
Comment on attachment 271193 [details] Patch for landing Clearing flags on attachment: 271193 Committed r196492: <http://trac.webkit.org/changeset/196492>
WebKit Commit Bot
Comment 6 2016-02-12 12:15:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.