Bug 154120

<rdar://problem/24613231>

Created attachment 271137 [details] WIP Patch

Attachment 271137 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:123: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 271137 [details] WIP Patch Attachment 271137 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/818123 New failing tests: js/dom/line-column-numbers.html http/tests/security/postMessage/delivery-order.html http/tests/security/postMessage/target-origin.html http/tests/security/postMessage/origin-unaffected-by-base-tag.html fast/dom/Window/window-postmessage-clone-frames.html http/tests/security/postMessage/javascript-page-still-sends-origin.html fast/frames/sandboxed-iframe-close-top-noclose.html http/tests/security/postMessage/data-url-sends-null-origin.html sputnik/Unicode/Unicode_320/S7.6_A3.1.html http/tests/security/cross-frame-access-put.html http/tests/security/postMessage/origin-unaffected-by-document-domain.html http/tests/security/isolatedWorld/document-open.html http/tests/messaging/cross-domain-message-send.html http/tests/security/postMessage/invalid-origin-throws-exception.html

Created attachment 271140 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 271137 [details] WIP Patch Attachment 271137 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/818124 New failing tests: js/dom/line-column-numbers.html http/tests/security/postMessage/delivery-order.html http/tests/security/postMessage/data-url-sends-null-origin.html http/tests/security/postMessage/target-origin.html http/tests/security/postMessage/origin-unaffected-by-base-tag.html fast/frames/sandboxed-iframe-close-top-noclose.html http/tests/security/postMessage/javascript-page-still-sends-origin.html sputnik/Unicode/Unicode_320/S7.6_A3.1.html http/tests/security/postMessage/origin-unaffected-by-document-domain.html http/tests/security/isolatedWorld/document-open.html http/tests/messaging/cross-domain-message-send.html http/tests/security/postMessage/invalid-origin-throws-exception.html

Created attachment 271142 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 271137 [details] WIP Patch Attachment 271137 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/818128 New failing tests: http/tests/security/postMessage/delivery-order.html http/tests/security/postMessage/target-origin.html http/tests/security/postMessage/origin-unaffected-by-base-tag.html fast/dom/Window/window-postmessage-clone-frames.html http/tests/security/postMessage/javascript-page-still-sends-origin.html fast/frames/sandboxed-iframe-close-top-noclose.html http/tests/security/postMessage/data-url-sends-null-origin.html sputnik/Unicode/Unicode_320/S7.6_A3.1.html http/tests/security/cross-frame-access-put.html http/tests/security/postMessage/origin-unaffected-by-document-domain.html http/tests/security/isolatedWorld/document-open.html http/tests/messaging/cross-domain-message-send.html http/tests/security/postMessage/invalid-origin-throws-exception.html

Created attachment 271146 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 271215 [details] WIP Patch

Attachment 271215 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:264: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 271219 [details] WIP Patch

For some reason, with this patch (same origin): window.open = function() { alert("test" }; }; console.log(window.open); -> function open() { [native code] } Unless we have already reified Window, then: window.open = function() { alert("test" }; }; console.log(window.open); -> function() { alert("test" }; }; Trying to figure out the reason.

(In reply to comment #13) > For some reason, with this patch (same origin): > window.open = function() { alert("test" }; }; > console.log(window.open); > -> function open() { [native code] } > > Unless we have already reified Window, then: > window.open = function() { alert("test" }; }; > console.log(window.open); > -> function() { alert("test" }; }; > > Trying to figure out the reason. Interestingly: window.open = function() { alert("test" }; }; console.log(window.open); -> function open() { [native code] } window.open = function() { alert("test" }; }; console.log(window.open); -> function() { alert("test" }; };

Comment on attachment 271219 [details] WIP Patch Attachment 271219 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/821584 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/isolatedWorld/document-open.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271230 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 271219 [details] WIP Patch Attachment 271219 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/821593 New failing tests: http/tests/security/isolatedWorld/document-open.html

Created attachment 271231 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 271219 [details] WIP Patch Attachment 271219 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/821619 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/isolatedWorld/document-open.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271232 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 271357 [details] WIP Patch (rebaselined)

Comment on attachment 271357 [details] WIP Patch (rebaselined) Attachment 271357 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/836843 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/isolatedWorld/document-open.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271366 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 271357 [details] WIP Patch (rebaselined) Attachment 271357 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/836848 New failing tests: http/tests/security/isolatedWorld/document-open.html

Created attachment 271367 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 271357 [details] WIP Patch (rebaselined) Attachment 271357 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/836842 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/isolatedWorld/document-open.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271368 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 271392 [details] WIP Patch

Comment on attachment 271392 [details] WIP Patch Attachment 271392 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/837849 New failing tests: jquery/offset.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271401 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 271392 [details] WIP Patch Attachment 271392 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/837844 New failing tests: jquery/offset.html

Created attachment 271402 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 271392 [details] WIP Patch Attachment 271392 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/837872 New failing tests: jquery/offset.html fast/dom/Window/window-postmessage-clone-frames.html

Created attachment 271405 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 271417 [details] WIP Patch

Created attachment 271429 [details] WIP Patch

Created attachment 271434 [details] Patch

Comment on attachment 271434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271434&action=review > Source/JavaScriptCore/runtime/Lookup.h:270 > Please add a comment above putEntry, explaining that: (1) base means the object holding the property (possibly in the prototype chain of the object put was called on). (2) thisValue is the object that put is being applied to (in the case of a proxy, the proxy target). (3) slot.thisValue() is the object the put was originally performed on (in the case of a proxy, the proxy itself). > Source/JavaScriptCore/runtime/Lookup.h:281 > + JSValue updateThisValue = entry->attributes() & CustomAccessor ? thisValue : JSValue(base); Please switch thisValue -> slot.thisValue().

Created attachment 271466 [details] Patch

Comment on attachment 271466 [details] Patch Clearing flags on attachment: 271466 Committed r196648: <http://trac.webkit.org/changeset/196648>

All reviewed patches have been landed. Closing bug.