Bug 153825

Summary: [css-grid] Fix percentage tracks' size computation in grids with gutters
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, commit-queue, darin, esprehn+autocc, glenn, jfernandez, kling, koivisto, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Patch darin: review+

Sergio Villar Senin
Reported Wednesday, February 3, 2016 9:09:50 AM UTC
[css-grid] Fix percentage tracks' size computation in grids with gutters
Attachments
Patch (9.28 KB, patch)
2016-02-03 01:16 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-yosemite (792.26 KB, application/zip)
2016-02-03 02:23 PST, Build Bot 		no flags
Details
Patch (9.30 KB, patch)
2016-03-17 09:13 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 Wednesday, February 3, 2016 9:16:08 AM UTC
Created attachment 270567 [details] Patch
Build Bot
Comment 2 Wednesday, February 3, 2016 10:23:48 AM UTC
Comment on attachment 270567 [details] Patch Attachment 270567 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/776323 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html
Build Bot
Comment 3 Wednesday, February 3, 2016 10:23:51 AM UTC
Created attachment 270568 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Sergio Villar Senin
Comment 4 Thursday, February 4, 2016 9:39:31 AM UTC
(In reply to comment #3) > Created attachment 270568 [details] > Archive of layout-test-results from ews113 for mac-yosemite > > The attached test failures were seen while running run-webkit-tests on the > mac-debug-ews. > Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5 This is totally unrelated.
Manuel Rego Casasnovas
Comment 5 Thursday, February 4, 2016 11:30:40 AM UTC
Comment on attachment 270567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270567&action=review The patch LGTM but I'm missing tests for rows in grid-gutters-and-tracks.html. > LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html:23 > +.gridWithPercent { -webkit-grid-template-columns: 10px 20% repeat(2, 30px); } Weird that you're defining 4 columns and only using 3. > LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html:26 > +.fixedSize { width: 220px; } I'll call this class "width220". > LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html:110 > + <div class="firstRowFirstColumn sizedToGridArea" data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="20"></div> I think you don't need sizedToGridArea for these items. > LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html:135 > + <div class="firstRowFirstColumn sizedToGridArea" data-offset-x="0" data-offset-y="0" data-expected-width="132" data-expected-height="20"></div> Ditto.
Sergio Villar Senin
Comment 6 Thursday, March 17, 2016 5:13:53 PM UTC
Created attachment 274295 [details] Patch Now with tests for rows. Also removed sizedToGridArea class
Sergio Villar Senin
Comment 7 Monday, March 21, 2016 11:42:43 AM UTC
Committed r198486: <http://trac.webkit.org/changeset/198486>
Note You need to log in before you can comment on or make changes to this bug.