Bug 153764
| Summary: | [iOS Simulator] fast/viewport/viewport-warnings-7.html failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, darin, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | iPhone / iPad | ||
| OS: | iOS 9.0 | ||
| Bug Depends on: | |||
| Bug Blocks: | 152130 | ||
Ryan Haddad
[iOS Simulator] fast/viewport/viewport-warnings-7.html failing
<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r195975%20(2771)/results.html>
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fviewport%2Fviewport-warnings-7.html>
--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/viewport-warnings-7-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/viewport-warnings-7-actual.txt
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: line 5: Viewport argument value "123i̇" for key "width" was truncated to its numeric prefix.
+CONSOLE MESSAGE: line 5: Viewport argument value "123İ" for key "width" was truncated to its numeric prefix.
ALERT: viewport size 123x135.3 scale 2.60163 with limits [2.60163, 5] and userScalable true
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
Failing since <http://trac.webkit.org/changeset/195951>
Alexey Proskuryakov
This is a progression, please feel free to just update iOS results.
That said, it seems wrong that we log a transformed variant of the value instead of the original.
Darin Adler
I believe the old code was logging a transformed variant of the value. The new code logs the original. That’s what the progression is.
Darin Adler
Ryan, will you update the iOS expected result or would you like me to do it?
Darin Adler
Yes, confirmed. This new result logs the original value. So the progression is not because we longer lowercase non-ASCII characters; it’s because the new code doesn’t lowercase anything at all, and logs the original value.
Darin Adler
http://trac.webkit.org/changeset/196047