Bug 153658

Summary: B3 should have documentation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
timothy: review+
the patch saam: review+

Filip Pizlo
Reported 2016-01-29 11:15:18 PST
Patch forthcoming.
Attachments
the patch (8.34 KB, patch)
2016-01-29 11:16 PST, Filip Pizlo 		timothy: review+
DetailsFormatted DiffDiff
the patch (47.97 KB, patch)
2016-01-29 13:38 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-29 11:16:35 PST
Created attachment 270227 [details] the patch
Filip Pizlo
Comment 2 2016-01-29 11:18:56 PST
Comment on attachment 270227 [details] the patch Landing myself.
Saam Barati
Comment 3 2016-01-29 11:26:18 PST
Comment on attachment 270227 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270227&action=review r=me > Websites/webkit.org/docs/b3/bare-bones-backend.md:21 > + printf("%d\n", function(42)); // prints 43 // prints 44 > Websites/webkit.org/docs/b3/bare-bones-backend.md:95 > +Note that the "@" references indicate the origin of the instruction in the B3 IR. I'd move this sentence up to the unoptimized Air IR above.
Filip Pizlo
Comment 4 2016-01-29 13:36:31 PST
Landed in http://trac.webkit.org/changeset/195830. But I will change it.
Filip Pizlo
Comment 5 2016-01-29 13:38:55 PST
Created attachment 270249 [details] the patch
Saam Barati
Comment 6 2016-01-29 13:42:32 PST
Comment on attachment 270249 [details] the patch LGTM
Filip Pizlo
Comment 7 2016-01-29 15:00:58 PST
Landed in http://trac.webkit.org/changeset/195841
Note You need to log in before you can comment on or make changes to this bug.