Bug 153394

Summary:

mandreel should run just as fast in FTL B3 as FTL LLVM

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

150279

Attachments:

Description	Flags
work so far	none
the patch	barraclough: review+
current standings	none

Filip Pizlo

Reported 2016-01-22 21:46:42 PST

Patch forthcoming.

Attachments
work so far (12.17 KB, patch) 2016-01-22 21:47 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (34.27 KB, patch) 2016-01-22 23:44 PST, Filip Pizlo	barraclough: review+	Details Formatted Diff Diff
current standings (81.20 KB, text/plain) 2016-01-23 00:32 PST, Filip Pizlo	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-01-22 21:47:51 PST

Created attachment 269648 [details] work so far Contains two optimizations: - Branch on something that was already Checked should be turned into a Jump to the notTaken path. - Gotta do more store-math-load fusion.

Filip Pizlo

Comment 2 2016-01-22 23:44:49 PST

Created attachment 269658 [details] the patch

WebKit Commit Bot

Comment 3 2016-01-22 23:45:59 PST

Attachment 269658 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3ReduceStrength.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:233: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:234: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:235: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:243: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 8 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 4 2016-01-23 00:32:45 PST

Created attachment 269659 [details] current standings

Gavin Barraclough

Comment 5 2016-01-25 11:49:26 PST

Comment on attachment 269658 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=269658&action=review > Source/JavaScriptCore/assembler/X86Assembler.h:455 > + m_formatter.oneByteOp8(OP_ADD_EvGv, src, base, offset); Per conversation probably doesn't need to be oneByteOp8, in a future patch. > Source/JavaScriptCore/b3/B3PureCSE.cpp:54 > + Matches& matches = m_map.add(key, Matches()).iterator->value; add –> find > Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:243 > + mkasm(u, "l"); indentation!

Filip Pizlo

Comment 6 2016-01-25 12:48:51 PST

Landed in http://trac.webkit.org/changeset/195549

Note You need to log in before you can comment on or make changes to this bug.