Bug 153386

Summary: B3 should strength-reduce division by a constant
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150507    
Attachments:
Description Flags
the patch benjamin: review+

Filip Pizlo
Reported 2016-01-22 17:54:39 PST
Patch forthcoming.
Attachments
the patch (17.85 KB, patch)
2016-01-22 17:59 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-22 17:59:03 PST
Created attachment 269627 [details] the patch
WebKit Commit Bot
Comment 2 2016-01-22 18:00:16 PST
Attachment 269627 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:125: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:126: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:127: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:128: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:129: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:130: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:133: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:134: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:135: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:135: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:139: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:140: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141: Missing space after , [whitespace/comma] [3] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:146: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:150: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:151: One space before end of line comments [whitespace/comments] [5] Total errors found: 18 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-01-22 19:40:32 PST
Landed in http://trac.webkit.org/changeset/195503
Note You need to log in before you can comment on or make changes to this bug.