Bug 152932

Summary: Add DisplayList hooks into GraphicsContext
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 152808    
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Simon Fraser (smfr)
Reported 2016-01-08 15:20:45 PST
Add DisplayList hooks into GraphicsContext
Attachments
Patch (25.64 KB, patch)
2016-01-08 15:25 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (25.63 KB, patch)
2016-01-08 15:28 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-01-08 15:25:20 PST
Created attachment 268593 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-01-08 15:28:33 PST
Created attachment 268594 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-01-08 17:42:16 PST
https://trac.webkit.org/r194814
Said Abou-Hallawa
Comment 4 2016-01-08 17:52:36 PST
Comment on attachment 268594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268594&action=review > Source/WebCore/platform/graphics/GraphicsContext.cpp:516 > clearPlatformShadow(); Instead of changing all the GraphicsContext functions, can't we change for example clearPlatformShadow() to be like this: void GraphicsContext::clearPlatformShadow() { return isRecording() ? m_displayListRecorder->clearShadow() : NativeClearPlatformShadow(); } void GraphicsContext::NativeClearPlatformShadow() { if (paintingDisabled()) return; CGContextSetShadowWithColor(platformContext(), CGSizeZero, 0, 0); }
Note You need to log in before you can comment on or make changes to this bug.