Bug 152850

Summary:

FTL B3 PutById should do exceptions

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, ryanhaddad, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

151686

Attachments:

Description	Flags
the patch	none
the patch	saam: review+

Filip Pizlo

Reported 2016-01-07 13:29:08 PST

Patch forthcoming.

Attachments
the patch (17.35 KB, patch) 2016-01-07 14:11 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (16.78 KB, patch) 2016-01-07 14:11 PST, Filip Pizlo	saam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-01-07 14:11:30 PST

Created attachment 268486 [details] the patch

Filip Pizlo

Comment 2 2016-01-07 14:11:58 PST

Created attachment 268487 [details] the patch

Saam Barati

Comment 3 2016-01-07 14:13:13 PST

Comment on attachment 268487 [details] the patch r=me

Filip Pizlo

Comment 4 2016-01-07 15:00:36 PST

Landed in http://trac.webkit.org/changeset/194730

Ryan Haddad

Comment 5 2016-01-07 15:43:31 PST

** The following JSC stress test failures have been introduced: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-no-inline-validate stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-validate <https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore-test/logs/stdio>

Filip Pizlo

Comment 6 2016-01-07 15:54:14 PST

(In reply to comment #5) > ** The following JSC stress test failures have been introduced: > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager- > no-cjit > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit- > no-inline-validate > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit- > validate > > <https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore- > test/logs/stdio> I'm on it.

Filip Pizlo

Comment 7 2016-01-07 16:01:48 PST

(In reply to comment #6) > (In reply to comment #5) > > ** The following JSC stress test failures have been introduced: > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager- > > no-cjit > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit- > > no-inline-validate > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit- > > validate > > > > <https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore- > > test/logs/stdio> > > I'm on it. Fixed in http://trac.webkit.org/changeset/194740.

Note You need to log in before you can comment on or make changes to this bug.