Bug 152748

Summary: Rename badly named JSC_timeout env var to JSCTEST_timeout.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: Tools / TestsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 153204    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. ggaren: review+

Mark Lam
Reported 2016-01-05 12:26:49 PST
Now that we validate JSC options, the badly named JSC_timeout env var causes the bots to have a bad time.
Attachments
proposed patch. (3.86 KB, patch)
2016-01-05 12:30 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-01-05 12:30:47 PST
Created attachment 268307 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-01-05 12:41:55 PST
Comment on attachment 268307 [details] proposed patch. r=me
Mark Lam
Comment 3 2016-01-05 12:57:54 PST
Thanks for the review. Landed in r194601: <http://trac.webkit.org/r194601>.
Csaba Osztrogonác
Comment 4 2016-01-18 03:10:43 PST
(In reply to comment #0) > Now that we validate JSC options, the badly named JSC_timeout env var causes > the bots to have a bad time. I don't understand this change at all. I can't find any references to JSCTEST_timeout in the source code. jsc still uses JSC_timeout environment variable. That's why we have many stucked jsc processes on the ARM64 Linux tester bot. I already set JSC_timeout locally to avoid stucked processes. But we need a proper fix, for example changing jsc behaviour too or rolling out this patch.
Csaba Osztrogonác
Comment 5 2016-01-18 04:27:33 PST
I got the goal of this change, and uploaded the fix in bug153204 .
Note You need to log in before you can comment on or make changes to this bug.