Bug 152744

Summary: FTL B3 should do In
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151808    
Attachments:
Description Flags
the patch
none
the patch
msaboff: review+
patch for landing none

Filip Pizlo
Reported 2016-01-05 11:47:37 PST
Patch forthcoming.
Attachments
the patch (6.21 KB, patch)
2016-01-05 11:49 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (5.63 KB, patch)
2016-01-05 11:49 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing (5.93 KB, patch)
2016-01-05 12:12 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-05 11:49:02 PST
Created attachment 268299 [details] the patch
Filip Pizlo
Comment 2 2016-01-05 11:49:56 PST
Created attachment 268300 [details] the patch
Filip Pizlo
Comment 3 2016-01-05 11:50:57 PST
Comment on attachment 268300 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268300&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-6099 > - speculateObject(base, cell); I'm removing this because it wasn't ever necessary to begin with. I don't know why this was there. I'm running extra tests to make sure I didn't break trunk since I'm also removing this in the LLVM case.
Michael Saboff
Comment 4 2016-01-05 11:52:44 PST
Comment on attachment 268300 [details] the patch r=me
WebKit Commit Bot
Comment 5 2016-01-05 11:52:59 PST
Attachment 268300 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6106: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6138: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2016-01-05 12:12:10 PST
Created attachment 268303 [details] patch for landing
WebKit Commit Bot
Comment 7 2016-01-05 12:13:05 PST
Attachment 268303 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6106: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6138: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2016-01-05 12:40:04 PST
Landed in http://trac.webkit.org/changeset/194598
Note You need to log in before you can comment on or make changes to this bug.