Bug 152709

Summary: FTL B3 should do all of the non-bitop binary snippets
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 152668    
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2016-01-04 12:55:16 PST
Patch forthcoming.
Attachments
the patch (6.66 KB, patch)
2016-01-04 13:07 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-04 13:07:46 PST
Created attachment 268226 [details] the patch
Mark Lam
Comment 2 2016-01-04 13:12:28 PST
Comment on attachment 268226 [details] the patch I think these tests are already covered by the op_mul.js, op_div.js, op_add.js stress tests. If there are missing operand value cases, you can just add the values to those tests.
Mark Lam
Comment 3 2016-01-04 13:31:19 PST
(In reply to comment #2) > Comment on attachment 268226 [details] > the patch > > I think these tests are already covered by the op_mul.js, op_div.js, > op_add.js stress tests. If there are missing operand value cases, you can > just add the values to those tests. Talked to Fil offline. He pointed out that these tests run for 100000 iterations and are targetted towards the FTL, whereas the pre-existing tests only iterate up to 10000. Rather than making the comprehensive tests wait for 100000 iterations, I'm ok with having these additional small test subsets just for the ftl.
Filip Pizlo
Comment 4 2016-01-04 13:34:11 PST
Landed in http://trac.webkit.org/changeset/194553
Note You need to log in before you can comment on or make changes to this bug.