Bug 152514

Summary: FTL B3 should be able to run richards
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cdumez, cmarcelo, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
almost there
none
the patch msaboff: review+

Filip Pizlo
Reported 2015-12-22 14:14:41 PST
It doesn't right now. It crashes.
Attachments
almost there (10.70 KB, patch)
2015-12-22 17:11 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (10.10 KB, patch)
2015-12-22 17:22 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-22 15:38:15 PST
This looks like a register allocation bug. A patchpoint is clobbering all volatile registers, but we still use %rdx across the patchpoint.
Filip Pizlo
Comment 2 2015-12-22 17:11:33 PST
Created attachment 267810 [details] almost there Just need to run a few more tests.
Filip Pizlo
Comment 3 2015-12-22 17:22:57 PST
Created attachment 267811 [details] the patch
Michael Saboff
Comment 4 2015-12-22 17:30:22 PST
Comment on attachment 267811 [details] the patch r=me
Filip Pizlo
Comment 5 2015-12-22 17:39:40 PST
(In reply to comment #4) > Comment on attachment 267811 [details] > the patch > > r=me Thanks!
Filip Pizlo
Comment 6 2015-12-22 17:51:00 PST
Landed in http://trac.webkit.org/changeset/194382
Benjamin Poulain
Comment 7 2015-12-23 11:21:26 PST
Comment on attachment 267811 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267811&action=review > Source/JavaScriptCore/ChangeLog:12 > + The liveness bug was that the code that determined whether we should go around the fixpoint > + assumed that BitVector::quickSet() would return true if the bit changed state from false to > + true. That's not how it works. It returns the old value of the bit, so it will return false Arg, quickSet() is the invert of add() on sets. Good catch.
Note You need to log in before you can comment on or make changes to this bug.