Bug 152232

Summary: [JSC] Add signExtend8To64 / signExtend16To64
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: chi187, curtisrencher7, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218990
Bug Depends on:    
Bug Blocks: 154319    
Attachments:
Description Flags
WIP
none
WIP none

Filip Pizlo
Reported 2015-12-13 15:18:32 PST
Currently we do the two sign extensions separately.
Attachments
WIP (12.91 KB, patch)
2020-11-30 16:51 PST, Sergey Rubanov 		no flags
DetailsFormatted DiffDiff
WIP (14.65 KB, patch)
2021-12-25 21:23 PST, Sergey Rubanov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sergey Rubanov
Comment 1 2020-11-30 16:51:51 PST
Created attachment 415079 [details] WIP
Yusuke Suzuki
Comment 2 2020-11-30 16:57:13 PST
Comment on attachment 415079 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=415079&action=review Some early comments. Nice. And I recommend adding tests to testair / testb3 when modifying Air / B3. > Source/JavaScriptCore/b3/air/AirOpcode.opcodes:670 > +SignExtend8To64 U:G:8, D:G:Ptr Let's not use Ptr here, and instead, let's use 64. It is also nice if we can define SignExtend32To64 as well :) > Source/JavaScriptCore/b3/air/AirOpcode.opcodes:673 > +SignExtend16To64 U:G:16, D:G:Ptr Ditto. > Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:-4627 > auto temp = g32(); > append(Move32, arg0, temp); > - append(SignExtend8To32, temp, temp); > - append(SignExtend32ToPtr, temp, result); Let's just make `append(SignExtend8To64, arg0, result);`. We do not need to have temp :) > Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:4635 > auto temp = g32(); > append(Move32, arg0, temp); > - append(SignExtend16To32, temp, temp); > - append(SignExtend32ToPtr, temp, result); > + append(SignExtend16To64, temp, result); Ditto.
Sergey Rubanov
Comment 3 2020-11-30 16:57:56 PST
Comment on attachment 415079 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=415079&action=review > Source/JavaScriptCore/b3/B3Opcode.cpp:220 > + out.print("SExt8To64"); out.print("SExt16To64");
Sergey Rubanov
Comment 4 2021-12-25 21:23:59 PST
Created attachment 447968 [details] WIP
Radar WebKit Bug Importer
Comment 6 2023-03-10 15:09:57 PST
<rdar://problem/106574794>
Yusuke Suzuki
Comment 7 2023-03-10 15:11:25 PST
Pull request: https://github.com/WebKit/WebKit/pull/11386
EWS
Comment 8 2023-03-14 16:54:14 PDT
Committed 261660@main (1fac7761b9cd): <https://commits.webkit.org/261660@main> Reviewed commits have been landed. Closing PR #11386 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.