Bug 152212

Summary: Web Inspector: "Selected Element" should use sans-serif font, not monospace
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Actual/expected
none
Patch
none
[Animated GIF] Actual/expected
none
Patch none

Nikita Vasilyev
Reported 2015-12-11 22:08:48 PST
Created attachment 267220 [details] [Animated GIF] Actual/expected "Selected Element" isn't code and isn't editable. It shouldn't be monospace.
Attachments
[Animated GIF] Actual/expected (8.25 KB, image/gif)
2015-12-11 22:08 PST, Nikita Vasilyev 		no flags
Details
Patch (1.28 KB, patch)
2015-12-11 22:10 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] Actual/expected (5.94 KB, image/gif)
2015-12-12 00:39 PST, Nikita Vasilyev 		no flags
Details
Patch (1.37 KB, patch)
2015-12-12 00:41 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-12-11 22:09:04 PST
<rdar://problem/23870644>
Nikita Vasilyev
Comment 2 2015-12-11 22:10:10 PST
Created attachment 267221 [details] Patch
Joseph Pecoraro
Comment 3 2015-12-12 00:16:12 PST
Err, in the gif the sans-serif version looks too fat to me. The blue background grew up and down, and it looks unbalanced around the text.
Nikita Vasilyev
Comment 4 2015-12-12 00:39:26 PST
Created attachment 267229 [details] [Animated GIF] Actual/expected (In reply to comment #3) > Err, in the gif the sans-serif version looks too fat to me. The blue > background grew up and down, and it looks unbalanced around the text. Now?
Nikita Vasilyev
Comment 5 2015-12-12 00:41:04 PST
Created attachment 267230 [details] Patch
Timothy Hatcher
Comment 6 2015-12-12 08:46:13 PST
New version looks better.
WebKit Commit Bot
Comment 7 2015-12-12 09:32:39 PST
Comment on attachment 267230 [details] Patch Clearing flags on attachment: 267230 Committed r194008: <http://trac.webkit.org/changeset/194008>
WebKit Commit Bot
Comment 8 2015-12-12 09:32:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.