Bug 152179

Summary: Modern IDB: Updates to 3 intversion tests, and/or their results
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1
none
Patch v2
none
Patch v3 none

Brady Eidson
Reported 2015-12-11 10:50:19 PST
Modern IDB: Updates to 3 intversion tests, and/or their results
Attachments
Patch v1 (5.12 KB, patch)
2015-12-11 10:52 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 (5.94 KB, patch)
2015-12-11 11:01 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v3 (5.94 KB, patch)
2015-12-11 11:58 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-12-11 10:52:06 PST
Created attachment 267174 [details] Patch v1
Brady Eidson
Comment 2 2015-12-11 11:01:39 PST
Created attachment 267175 [details] Patch v2
Brady Eidson
Comment 3 2015-12-11 11:02:12 PST
This might not apply to trunk because it relies on patches from 152175 and 152177 It's still correct and reviewable.
Alex Christensen
Comment 4 2015-12-11 11:27:08 PST
Comment on attachment 267175 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=267175&action=review > LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24 > -PASS event.target.result is null > +FAIL event.target.result should be undefined. Was null What's this?
Brady Eidson
Comment 5 2015-12-11 11:58:02 PST
Created attachment 267180 [details] Patch v3
Brady Eidson
Comment 6 2015-12-11 13:30:21 PST
(In reply to comment #4) > Comment on attachment 267175 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267175&action=review > > > LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24 > > -PASS event.target.result is null > > +FAIL event.target.result should be undefined. Was null > > What's this? As we went over in person - WK2 (Legacy IDB) is known to get this wrong, so it is "correct" for WK2 to output a "FAIL" here.
WebKit Commit Bot
Comment 7 2015-12-11 14:13:06 PST
Comment on attachment 267180 [details] Patch v3 Clearing flags on attachment: 267180 Committed r193980: <http://trac.webkit.org/changeset/193980>
WebKit Commit Bot
Comment 8 2015-12-11 14:13:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.