Bug 152135

Summary: [iOS Simulator] fast/viewport/ios/width-is-device-width-overflowing* tests failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 9.0   
Bug Depends on:    
Bug Blocks: 152130    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2015-12-10 09:10:28 PST
[iOS Simulator] fast/viewport/ios/width-is-device-width-overflowing* tests failing fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit.html fast/viewport/ios/width-is-device-width-overflowing.html <https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r193902%20(1662)/results.html>
Attachments
Patch (6.86 KB, patch)
2015-12-15 16:56 PST, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2015-12-14 13:04:37 PST
Marked as failing on iOS simulator in <http://trac.webkit.org/changeset/194053>
Ryan Haddad
Comment 2 2015-12-14 14:13:02 PST
Missed the ios-simulator-wk2 [ Pass ] expectation. Removed with r194058.
Alexey Proskuryakov
Comment 3 2015-12-14 20:23:22 PST
Could you please post the failure into the bug? There is one more test in this directory, width-is-device-width.html. Looks like it was passing, but as a result of these changes, it got skipped.
Ryan Haddad
Comment 4 2015-12-14 20:36:15 PST
Of course. Sorry about the collateral damage there. Diffs below: --- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-actual.txt @@ -1,7 +1,7 @@ Viewport: width=device-width -scale 1.00000 +scale 1.05263 maxScale 5.00000 -minScale 1.00000 -visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"} +minScale 1.05263 +visibleRect {"left":"0.00000","top":"0.00000","width":"303.99999","height":"455.99998"} --- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-actual.txt @@ -1,7 +1,7 @@ Viewport: width=device-width -scale 1.00000 +scale 5.00000 maxScale 5.00000 -minScale 0.32653 -visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"} +minScale 5.00000 +visibleRect {"left":"0.00000","top":"0.00000","width":"64.00000","height":"96.00000"} --- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-actual.txt @@ -1,7 +1,7 @@ Viewport: width=device-width, shrink-to-fit=no -scale 0.32653 +scale 1.00000 maxScale 5.00000 -minScale 0.32653 -visibleRect {"left":"0.00000","top":"0.00000","width":"980.00000","height":"1470.00000"} +minScale 1.00000 +visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"} --- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/ios/width-is-device-width-overflowing-actual.txt @@ -1,7 +1,7 @@ Viewport: width=device-width -scale 1.00000 +scale 0.31746 maxScale 5.00000 -minScale 1.00000 -visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"} +minScale 0.31746 +visibleRect {"left":"0.00000","top":"0.00000","width":"1007.99997","height":"1511.99995"}
Tim Horton
Comment 5 2015-12-15 09:53:52 PST
I think this was "intentional", but you should talk to Simon.
Simon Fraser (smfr)
Comment 6 2015-12-15 15:56:36 PST
I didn't change anything here since those tests landed. Would be good to have a regression point.
Simon Fraser (smfr)
Comment 7 2015-12-15 16:52:58 PST
I think the new results are actually correct. I will confirm and rebaseline.
Ryan Haddad
Comment 8 2015-12-15 16:53:56 PST
I have a local change to rebaseline with the current results and update the TestExpectations files. Give me a few minutes and I'll upload it.
Ryan Haddad
Comment 9 2015-12-15 16:56:42 PST
Created attachment 267413 [details] Patch
WebKit Commit Bot
Comment 10 2015-12-15 19:10:17 PST
Comment on attachment 267413 [details] Patch Clearing flags on attachment: 267413 Committed r194129: <http://trac.webkit.org/changeset/194129>
WebKit Commit Bot
Comment 11 2015-12-15 19:10:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.