Bug 152005

Summary: Remove OverridesHasInstance from TypeInfoFlags
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151839    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2015-12-08 12:03:29 PST
This bit is no longer used in any runtime code and should be freed for others to use.
Attachments
Patch (22.30 KB, patch)
2015-12-18 19:00 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (22.67 KB, patch)
2015-12-18 20:02 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (22.70 KB, patch)
2015-12-21 09:53 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2015-12-18 19:00:57 PST
Created attachment 267676 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-18 19:01:49 PST
Attachment 267676 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:154: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2015-12-18 20:02:31 PST
Created attachment 267678 [details] Patch
WebKit Commit Bot
Comment 4 2015-12-18 20:04:21 PST
Attachment 267678 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:152: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 5 2015-12-21 09:53:57 PST
Created attachment 267752 [details] Patch
WebKit Commit Bot
Comment 6 2015-12-21 09:56:21 PST
Attachment 267752 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:152: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 7 2015-12-21 09:57:22 PST
Comment on attachment 267752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267752&action=review > Source/JavaScriptCore/llint/LLIntData.cpp:152 > + STATIC_ASSERT(GlobalCode == 0); This is intentionally compared with 0 so the static_assert message is clearer.
Saam Barati
Comment 8 2015-12-21 15:02:41 PST
Comment on attachment 267752 [details] Patch r=me
WebKit Commit Bot
Comment 9 2015-12-22 12:05:21 PST
Comment on attachment 267752 [details] Patch Clearing flags on attachment: 267752 Committed r194369: <http://trac.webkit.org/changeset/194369>
WebKit Commit Bot
Comment 10 2015-12-22 12:05:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.