Bug 151855

Summary: [AArch64] Typo fix after r189575
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 148666    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-12-04 03:17:25 PST
There is a typo introduced in http://trac.webkit.org/changeset/189575/trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp case UNW_ARM64_v21 should be changed to match to other places - append(RegisterAtOffset(ARM64Registers::q21, prolog.savedRegisters[i].offset + prolog.cfaRegisterOffset)); + registerOffsets->append(RegisterAtOffset(ARM64Registers::q21, prolog.savedRegisters[i].offset + prolog.cfaRegisterOffset)); We need this to fix the FTL build on AArch64.
Attachments
Patch (1.73 KB, patch)
2015-12-04 03:19 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-12-04 03:19:09 PST
Created attachment 266615 [details] Patch
Michael Saboff
Comment 2 2015-12-04 04:14:06 PST
Comment on attachment 266615 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-12-04 05:01:24 PST
Comment on attachment 266615 [details] Patch Clearing flags on attachment: 266615 Committed r193414: <http://trac.webkit.org/changeset/193414>
WebKit Commit Bot
Comment 4 2015-12-04 05:01:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.