Bug 151667

Summary: FTL lazy slow paths should work with B3
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, benjamin, commit-queue, ggaren, lohago5382, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sambadseo, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 151668    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
it compiles!
none
the patch ggaren: review+

Filip Pizlo
Reported 2015-11-30 12:08:14 PST
Patch forthcoming.
Attachments
work in progress (18.38 KB, patch)
2015-11-30 17:56 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it compiles! (22.43 KB, patch)
2015-11-30 19:01 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (25.79 KB, patch)
2015-11-30 19:37 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-30 17:56:40 PST
Created attachment 266310 [details] work in progress I haven't tried compiling it yet.
Filip Pizlo
Comment 2 2015-11-30 19:01:11 PST
Created attachment 266319 [details] it compiles!
Filip Pizlo
Comment 3 2015-11-30 19:37:59 PST
Created attachment 266326 [details] the patch
Filip Pizlo
Comment 4 2015-11-30 19:38:54 PST
Oh man, I'm playing the EWS lottery so hard - I haven't tested this with FTL_USES_B3 disabled.
WebKit Commit Bot
Comment 5 2015-11-30 19:39:48 PST
Attachment 266326 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7853: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7870: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7887: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 6 2015-11-30 19:43:19 PST
Comment on attachment 266326 [details] the patch r=me
Filip Pizlo
Comment 7 2015-11-30 20:43:58 PST
Landed in http://trac.webkit.org/changeset/192856
Note You need to log in before you can comment on or make changes to this bug.