Bug 151647

Summary: Modern IDB: Support updating cursor values when the object store uses inline keys
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1
none
Patch v1 (applies)
none
Patch v1 (really applies) aestes: review+

Brady Eidson
Reported 2015-11-29 11:41:46 PST
Modern IDB: Support updating cursor values when the object store uses inline keys
Attachments
Patch v1 (8.29 KB, patch)
2015-11-29 11:44 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 (applies) (8.36 KB, patch)
2015-11-30 10:30 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 (really applies) (8.37 KB, patch)
2015-11-30 10:39 PST, Brady Eidson 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-29 11:44:25 PST
Created attachment 266226 [details] Patch v1
Brady Eidson
Comment 2 2015-11-29 11:47:25 PST
Comment on attachment 266226 [details] Patch v1 This one relies on at least one of the other patches I have waiting in review, so unmarking for review at this time.
Brady Eidson
Comment 3 2015-11-30 10:30:29 PST
Created attachment 266249 [details] Patch v1 (applies)
Brady Eidson
Comment 4 2015-11-30 10:35:40 PST
Well, apparently this doesn't apply, even though I just made it from trunk! Other stuff have probably landed since I updated.
Brady Eidson
Comment 5 2015-11-30 10:39:07 PST
Created attachment 266252 [details] Patch v1 (really applies)
Andy Estes
Comment 6 2015-11-30 10:43:16 PST
Comment on attachment 266252 [details] Patch v1 (really applies) View in context: https://bugs.webkit.org/attachment.cgi?id=266252&action=review > Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp:228 > + auto idbKey = scriptValueToIDBKey(state, key); You don't need to use a local variable here.
Brady Eidson
Comment 7 2015-11-30 11:05:31 PST
https://trac.webkit.org/changeset/192806
Note You need to log in before you can comment on or make changes to this bug.