Bug 151370

Summary: Implement the B3 equivalent of FTLCompile
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 151371    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
the patch benjamin: review+

Filip Pizlo
Reported 2015-11-17 16:40:40 PST
Patch forthcoming.
Attachments
work in progress (11.52 KB, patch)
2015-11-17 17:57 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (22.63 KB, patch)
2015-11-18 14:52 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-17 17:57:26 PST
Created attachment 265724 [details] work in progress
Filip Pizlo
Comment 2 2015-11-18 14:52:47 PST
Created attachment 265784 [details] the patch
WebKit Commit Bot
Comment 3 2015-11-18 14:55:10 PST
Attachment 265784 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLB3Compile.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 4 2015-11-18 14:58:30 PST
Comment on attachment 265784 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=265784&action=review > Source/JavaScriptCore/b3/B3Procedure.cpp:151 > +RegisterAtOffsetList& Procedure::calleeSaveRegisters() Maybe const? I can't think of a valid change on the returned value. const RegisterAtOffsetList& Procedure::calleeSaveRegisters() const
Filip Pizlo
Comment 5 2015-11-18 15:04:02 PST
(In reply to comment #4) > Comment on attachment 265784 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265784&action=review > > > Source/JavaScriptCore/b3/B3Procedure.cpp:151 > > +RegisterAtOffsetList& Procedure::calleeSaveRegisters() > > Maybe const? I can't think of a valid change on the returned value. > const RegisterAtOffsetList& Procedure::calleeSaveRegisters() const True! :-)
Filip Pizlo
Comment 6 2015-11-18 15:06:47 PST
Landed in http://trac.webkit.org/changeset/192590
Note You need to log in before you can comment on or make changes to this bug.