Bug 151014

Summary: Modern IDB: Refactor memory objectstore/transaction interation
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150939    
Attachments:
Description Flags
Patch v1 none

Brady Eidson
Reported 2015-11-08 22:09:28 PST
Modern IDB: Refactor memory objectstore/transaction integration The only time object stores should ever notify transactions about changed records is when they are deleted. This works because even puts/adds are defined as undergoing a delete first. This also works such that when transactions abort, records are put back in to the database as normal. This is important because as we support indexes (https://bugs.webkit.org/show_bug.cgi?id=150939), indexes will rely on OS.delete removing a record and OS.put adding a record.
Attachments
Patch v1 (12.57 KB, patch)
2015-11-08 22:24 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-08 22:24:34 PST
Created attachment 265033 [details] Patch v1
Darin Adler
Comment 2 2015-11-09 09:48:22 PST
Comment on attachment 265033 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=265033&action=review > Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp:168 > + ASSERT(!m_orderedKeys || m_orderedKeys->find(keyData) == m_orderedKeys->end()); Why not use contains here instead of find==end?
Brady Eidson
Comment 3 2015-11-09 10:14:45 PST
(In reply to comment #2) > Comment on attachment 265033 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265033&action=review > > > Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp:168 > > + ASSERT(!m_orderedKeys || m_orderedKeys->find(keyData) == m_orderedKeys->end()); > > Why not use contains here instead of find==end? m_orderedKeys is a std::set, which apparently doesn't have ::contains() - Only find. :(
WebKit Commit Bot
Comment 4 2015-11-09 10:36:43 PST
Comment on attachment 265033 [details] Patch v1 Clearing flags on attachment: 265033 Committed r192163: <http://trac.webkit.org/changeset/192163>
WebKit Commit Bot
Comment 5 2015-11-09 10:36:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.