Bug 151010

Summary: MacroAssembler needs an API for disabling scratch registers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 151669    
Bug Blocks: 151008    
Attachments:
Description Flags
the patch
none
the patch saam: review+

Filip Pizlo
Reported 2015-11-08 18:22:00 PST
When the scratch registers are disabled, any instruction that uses them should CRASH. This should be used by Air::generate().
Attachments
the patch (84.52 KB, patch)
2015-11-30 11:57 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (52.66 KB, patch)
2015-11-30 11:58 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-30 11:57:23 PST
Created attachment 266255 [details] the patch
Filip Pizlo
Comment 2 2015-11-30 11:58:00 PST
Created attachment 266256 [details] the patch
Michael Saboff
Comment 3 2015-11-30 12:03:54 PST
r=me as well.
Filip Pizlo
Comment 4 2015-11-30 12:07:43 PST
Landed in http://trac.webkit.org/changeset/192812
WebKit Commit Bot
Comment 5 2015-11-30 12:34:56 PST
Re-opened since this is blocked by bug 151669
Filip Pizlo
Comment 6 2016-02-16 18:26:14 PST
This definitely relanded, don't remember when, but it was a long time ago.
Note You need to log in before you can comment on or make changes to this bug.