Bug 150994

Summary: B3->Air lowering should do pattern matching the old fashioned way
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
the patch ggaren: review+

Filip Pizlo
Reported 2015-11-06 20:11:13 PST
C++ and switch statements for the win.
Attachments
work in progress (32.24 KB, patch)
2015-11-06 20:12 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (83.65 KB, patch)
2015-11-06 22:15 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-06 20:12:27 PST
Created attachment 264993 [details] work in progress
Filip Pizlo
Comment 2 2015-11-06 22:15:18 PST
Created attachment 264996 [details] the patch
WebKit Commit Bot
Comment 3 2015-11-06 22:18:19 PST
Attachment 264996 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3LowerToAir.cpp:448: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/B3LowerToAir.cpp:1155: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 4 2015-11-07 13:01:02 PST
Comment on attachment 264996 [details] the patch r=me
Filip Pizlo
Comment 5 2015-11-07 18:11:40 PST
Landed in http://trac.webkit.org/changeset/192135
Note You need to log in before you can comment on or make changes to this bug.