Bug 150958

Summary:

B3::reduceStrength should canonicalize integer comparisons

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fpizlo, keith_miller, lforschler, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

150721

Bug Blocks:

154319, 183543

Attachments:

Description	Flags
Patch	none
Patch	none

Filip Pizlo

Reported 2015-11-05 15:06:51 PST

Integer comparisons are not necessarily commutative, but you can swap the operands if you also flip the comparison - for example you can turn LessThan(const, var) into GreaterThan(var, const). We should use this property to "sort" the operands the same way we do for commutative operations. This will let us get rid of a lot of cases in the B3::lowerToAir() pattern matching.

Attachments
Patch (10.88 KB, patch) 2018-03-10 12:10 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (10.80 KB, patch) 2018-03-10 12:11 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.