Bug 150854

Summary: Remove LegacyIDB
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mcatanzaro, ryanhaddad
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 151890, 154273    
Attachments:
Description Flags
Patch v1 none

Brady Eidson
Reported 2015-11-03 13:32:35 PST
Remove LegacyIDB This includes: -Removing the legacy/* directory -Removing the layer of inheritance between the abstract "IDBFoo" and "IDBFooImpl" objects -Doing a sweep of Deprecated::ScriptValue to JSValue replacement in those IDBFoo interfaces -Probably other stuff
Attachments
Patch v1 (756.28 KB, patch)
2016-02-25 12:03 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-26 21:32:11 PST
(In reply to comment #0) > Remove LegacyIDB > > This includes: > -Removing the legacy/* directory > -Removing the layer of inheritance between the abstract "IDBFoo" and > "IDBFooImpl" objects > -Doing a sweep of Deprecated::ScriptValue to JSValue replacement in those > IDBFoo interfaces > -Probably other stuff -Remove unnecessary cruft from IDBGetResult (marked by a fixme with this bug #)
Brady Eidson
Comment 2 2016-02-04 11:36:32 PST
*** Bug 153848 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 3 2016-02-04 11:36:38 PST
*** Bug 153849 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 4 2016-02-04 11:37:12 PST
(In reply to comment #1) > (In reply to comment #0) > > Remove LegacyIDB > > > > This includes: > > -Removing the legacy/* directory > > -Removing the layer of inheritance between the abstract "IDBFoo" and > > "IDBFooImpl" objects > > -Doing a sweep of Deprecated::ScriptValue to JSValue replacement in those > > IDBFoo interfaces > > -Probably other stuff > > -Remove unnecessary cruft from IDBGetResult (marked by a fixme with this bug > #) Removing the current WK2 specific TestExpectations for IndexedDB tests
Brady Eidson
Comment 5 2016-02-25 11:39:52 PST
After http://trac.webkit.org/changeset/197122, Legacy IDB is no longer needed. I'm writing the patch today.
Brady Eidson
Comment 6 2016-02-25 12:03:27 PST
Created attachment 272223 [details] Patch v1 Ready for review now. No cq? because I want all EWS to run first
Brady Eidson
Comment 7 2016-02-25 12:22:30 PST
(In reply to comment #4) > (In reply to comment #1) > > (In reply to comment #0) > > > Remove LegacyIDB > > > > > > This includes: > > > -Removing the legacy/* directory > > > -Removing the layer of inheritance between the abstract "IDBFoo" and > > > "IDBFooImpl" objects > > > -Doing a sweep of Deprecated::ScriptValue to JSValue replacement in those > > > IDBFoo interfaces > > > -Probably other stuff > > > > -Remove unnecessary cruft from IDBGetResult (marked by a fixme with this bug > > #) > > Removing the current WK2 specific TestExpectations for IndexedDB tests Most of these things weren't directly addressed in the huge patch up for review right now. That's okay. They'll come later.
WebKit Commit Bot
Comment 8 2016-02-25 14:19:04 PST
Comment on attachment 272223 [details] Patch v1 Clearing flags on attachment: 272223 Committed r197131: <http://trac.webkit.org/changeset/197131>
WebKit Commit Bot
Comment 9 2016-02-25 14:19:07 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 10 2016-02-25 15:01:26 PST
Congratulations Brady!
Note You need to log in before you can comment on or make changes to this bug.