Bug 150766

Summary:

[Vertical Writing Mode] Rename "vertical-right" CSS value to match spec

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, hyatt, jonlee, rniwa, simon.fraser, thorton, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

150765

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	darin: review+
Patch for committing	none
Patch for committing	none
Patch for committing	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-mavericks	none
Patch for committing	none

Myles C. Maxfield

Reported 2015-10-31 21:12:07 PDT

[Vertical Writing Mode] Rename "vertical-right" CSS value to match spec

Attachments
Patch (16.99 KB, patch) 2015-10-31 21:21 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-yosemite (913.40 KB, application/zip) 2015-10-31 22:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mavericks (703.81 KB, application/zip) 2015-10-31 22:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (735.99 KB, application/zip) 2015-10-31 22:21 PDT, Build Bot	no flags	Details
Patch (21.61 KB, patch) 2015-11-01 15:46 PST, Myles C. Maxfield	darin: review+	Details Formatted Diff Diff
Patch for committing (26.63 KB, patch) 2015-11-02 00:33 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (30.85 KB, patch) 2015-11-02 02:00 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (30.86 KB, patch) 2015-11-02 12:29 PST, Myles C. Maxfield	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (714.72 KB, application/zip) 2015-11-02 15:00 PST, Build Bot	no flags	Details
Patch for committing (33.18 KB, patch) 2015-11-02 17:30 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2015-10-31 21:21:53 PDT

Created attachment 264502 [details] Patch

Build Bot

Comment 2 2015-10-31 22:16:59 PDT

Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/365661 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 3 2015-10-31 22:17:03 PDT

Created attachment 264503 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2015-10-31 22:18:01 PDT

Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/365691 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 5 2015-10-31 22:18:05 PDT

Created attachment 264504 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 6 2015-10-31 22:20:57 PDT

Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/365695 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 7 2015-10-31 22:21:00 PDT

Created attachment 264505 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Darin Adler

Comment 8 2015-11-01 12:31:01 PST

Comment on attachment 264502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264502&action=review > Source/WebCore/css/CSSParser.cpp:3110 > + // FIXME: For now just support sideways, sideways-right, upright and vertical-right (mixed). This is a confusing FIXME. The old one matched the code just below it, the new comment does not. What’s the value of this comment? How about just deleting it unless there is something to non-obvious to say.

Myles C. Maxfield

Comment 9 2015-11-01 15:46:18 PST

Created attachment 264540 [details] Patch

Darin Adler

Comment 10 2015-11-01 17:11:58 PST

Comment on attachment 264540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264540&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:1827 > + return std::make_pair(Horizontal, NonCJKGlyphOrientationMixed); I think argument list syntax is superior: return { Horizontal, NonCJKGlyphOrientationMixed }; Unless it won’t work. > Source/WebCore/rendering/style/RenderStyle.h:713 > + std::pair<FontOrientation, NonCJKGlyphOrientation> getFontAndGlyphOrientation(); If you’re changing this to return a tuple then it should not be named “get” any more. We use “get” to mean “uses out arguments” and when we just return something, we name the function for what it’s returning.

Myles C. Maxfield

Comment 11 2015-11-02 00:33:49 PST

Created attachment 264566 [details] Patch for committing

Myles C. Maxfield

Comment 12 2015-11-02 02:00:32 PST

Created attachment 264569 [details] Patch for committing

Myles C. Maxfield

Comment 13 2015-11-02 12:29:57 PST

Created attachment 264614 [details] Patch for committing

Build Bot

Comment 14 2015-11-02 15:00:13 PST

Comment on attachment 264614 [details] Patch for committing Attachment 264614 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/373652 New failing tests: storage/indexeddb/modern/idbobjectstore-count-failures.html

Build Bot

Comment 15 2015-11-02 15:00:18 PST

Created attachment 264633 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Myles C. Maxfield

Comment 16 2015-11-02 17:06:39 PST

Test failures are unrelated.

Myles C. Maxfield

Comment 17 2015-11-02 17:30:09 PST

Created attachment 264649 [details] Patch for committing

WebKit Commit Bot

Comment 18 2015-11-02 19:54:25 PST

Comment on attachment 264649 [details] Patch for committing Clearing flags on attachment: 264649 Committed r191935: <http://trac.webkit.org/changeset/191935>

Note You need to log in before you can comment on or make changes to this bug.