Bug 150535

Summary: B3::Values that have effects should allow specification of custom HeapRanges
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
ggaren: review-
the patch benjamin: review+

Filip Pizlo
Reported 2015-10-24 12:41:32 PDT
Each memory-accessing operation has an integer range associated with it. Two things may access the same memory if their ranges overlap. We can also add ranges to calls and patchpoints.
Attachments
the patch (26.25 KB, patch)
2015-11-03 14:24 PST, Filip Pizlo 		ggaren: review-
DetailsFormatted DiffDiff
the patch (26.25 KB, patch)
2015-11-03 15:53 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-03 14:24:03 PST
Created attachment 264725 [details] the patch
WebKit Commit Bot
Comment 2 2015-11-03 14:26:23 PST
Attachment 264725 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-11-03 15:53:34 PST
Created attachment 264744 [details] the patch For real this time
Geoffrey Garen
Comment 4 2015-11-03 15:54:17 PST
Comment on attachment 264725 [details] the patch EWS is red.
WebKit Commit Bot
Comment 5 2015-11-03 15:56:30 PST
Attachment 264744 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2015-11-03 16:29:30 PST
Landed in http://trac.webkit.org/changeset/191994
Note You need to log in before you can comment on or make changes to this bug.