Bug 150534

Summary: StoreOpLoad pattern matching should check effects between the Store and Load
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2015-10-24 12:39:31 PDT
This will require having some kind of alias analysis in B3.
Attachments
the patch (13.62 KB, patch)
2015-10-29 13:25 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (14.33 KB, patch)
2015-10-29 13:36 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-10-29 13:25:21 PDT
Created attachment 264339 [details] the patch
WebKit Commit Bot
Comment 2 2015-10-29 13:26:50 PDT
Attachment 264339 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:390: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:391: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-10-29 13:36:08 PDT
Created attachment 264340 [details] the patch
WebKit Commit Bot
Comment 4 2015-10-29 13:37:47 PDT
Attachment 264340 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:390: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:391: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-10-29 14:26:02 PDT
Comment on attachment 264340 [details] the patch r=me
Filip Pizlo
Comment 6 2015-10-29 16:43:14 PDT
Landed in http://trac.webkit.org/changeset/191762
Note You need to log in before you can comment on or make changes to this bug.