Bug 150500

Summary: [GTK][Mac] disable OBJC JSC API
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: JavaScriptCoreAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2015-10-23 08:11:03 PDT
The Mac flavour of the GTK port can't really support this it seems.
Attachments
Patch (1.66 KB, patch)
2015-10-23 08:13 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.27 KB, patch)
2015-10-23 08:51 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-10-23 08:13:43 PDT
Created attachment 263925 [details] Patch
Philippe Normand
Comment 2 2015-10-23 08:51:33 PDT
Created attachment 263927 [details] Patch
Philippe Normand
Comment 3 2015-10-23 08:53:21 PDT
Comment on attachment 263927 [details] Patch oops
Alex Christensen
Comment 4 2015-10-29 20:38:32 PDT
Comment on attachment 263925 [details] Patch Sure, why not.
WebKit Commit Bot
Comment 5 2015-10-29 21:31:15 PDT
Comment on attachment 263925 [details] Patch Clearing flags on attachment: 263925 Committed r191775: <http://trac.webkit.org/changeset/191775>
WebKit Commit Bot
Comment 6 2015-10-29 21:31:18 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 7 2015-10-29 23:15:50 PDT
(In reply to comment #4) > Comment on attachment 263925 [details] > Patch > > Sure, why not. Just so nobody thinks I'm carelessly throwing things into the API, I am aware that this will break compiling any third party applications that use the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think that's worth having, though, to support GTK development. Why can't GTK on Mac support this, though?
Philippe Normand
Comment 8 2015-10-30 01:21:26 PDT
(In reply to comment #7) > (In reply to comment #4) > > Comment on attachment 263925 [details] > > Patch > > > > Sure, why not. > Just so nobody thinks I'm carelessly throwing things into the API, I am > aware that this will break compiling any third party applications that use > the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think > that's worth having, though, to support GTK development. > > Why can't GTK on Mac support this, though? I suppose it would be possible to support. All I want for now is a basic build of GTK for Mac. If more people are interested we enable the OBJC API later on.
Note You need to log in before you can comment on or make changes to this bug.