Bug 150430

Summary: Air needs syntax for escaping StackSlots
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-10-21 18:19:31 PDT
It'll need it because otherwise we won't be able to select instructions for the StackSlot Value except if it's always used by Load/Store.
Attachments
the patch (31.29 KB, patch)
2015-10-29 11:46 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-10-29 11:46:30 PDT
Created attachment 264328 [details] the patch
WebKit Commit Bot
Comment 2 2015-10-29 11:50:14 PDT
Attachment 264328 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/air/AirAllocateStack.cpp:112: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-10-29 11:50:53 PDT
Comment on attachment 264328 [details] the patch r=me
Filip Pizlo
Comment 4 2015-10-29 12:04:19 PDT
Hmmm, EWS is taking a long time. I'll wait a bit before landing.
Filip Pizlo
Comment 5 2015-10-29 12:17:42 PDT
Landed in http://trac.webkit.org/changeset/191745
Note You need to log in before you can comment on or make changes to this bug.