Bug 149890

Summary: [CSS Grid Layout] Fix grid-{row, column, area} shorthand CSSOM serialization
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, clopez, darin, jfernandez, karlcow, rego, sgill26, simon.fraser, svillar, webkit-bug-importer, zakr, zalan
Priority: P2 Keywords: BlinkMergeCandidate, BrowserCompat, GoodFirstBug, InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204506
Bug Depends on:    
Bug Blocks: 149891    
Attachments:
Description Flags
Patch svillar: review-

Javier Fernandez
Reported 2015-10-07 13:16:05 PDT
The grid-row, grid-column and grid-area shorthands must use slash instead of whitespace as separator.
Attachments
Patch (11.57 KB, patch)
2015-10-07 13:37 PDT, Javier Fernandez 		svillar: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-10-07 13:29:12 PDT
Fixing this bug would require to merge http://crrev.com/1132753002 patch.
Javier Fernandez
Comment 2 2015-10-07 13:37:54 PDT
Created attachment 262632 [details] Patch
Sergio Villar Senin
Comment 3 2015-10-08 05:08:57 PDT
Comment on attachment 262632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262632&action=review > Source/WebCore/css/CSSPropertyNames.in:493 > +-webkit-grid-area [Longhands=-webkit-grid-row-start|-webkit-grid-column-start|-webkit-grid-row-end|-webkit-grid-column-end] Wow this is bad. This means that we're expanding incorrectly the shorthand and that we have no tests to verify that. Please use a different bug to upload this change with its corresponding test.
Carlos Alberto Lopez Perez
Comment 4 2020-03-30 12:02:44 PDT
I think this is causing failures on the WPT test https://wpt.live/css/css-grid/parsing/grid-area-valid.html
Ahmad Saleem
Comment 5 2022-09-29 00:43:09 PDT
(In reply to Carlos Alberto Lopez Perez from comment #4) > I think this is causing failures on the WPT test > https://wpt.live/css/css-grid/parsing/grid-area-valid.html In this above test case: Safari 16 -> 24 Pass and 32 Fail Safari TP 154 -> 24 Pass and 32 Fail Chrome Canary 108 -> 24 Pass and 32 Fail Firefox Nightly 107 -> 56 Pass
Radar WebKit Bug Importer
Comment 6 2024-07-25 17:24:50 PDT
<rdar://problem/132530604>
zak ridouh
Comment 7 2024-08-13 00:32:47 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32101
EWS
Comment 8 2024-09-05 14:43:08 PDT
Committed 283234@main (3725a9f39e9d): <https://commits.webkit.org/283234@main> Reviewed commits have been landed. Closing PR #32101 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.